-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix inconsistencies across dropdown elements #21199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one relevant comment for this PR, that would be good to changed. Otherwise it's looking fine so far
plugins/Dashboard/tests/UI/expected-screenshots/DashboardManager_create_new.png
Show resolved
Hide resolved
… sub item dropdown icon
…o m20475-dropdown-adjustments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good now. Merged in the latest changes from 5.x-dev and will wait for the tests to finish before merging...
Apologies for my sometimes annoying sense for tiny details. I can't help it but I think the new chevron icon for the dropdown is too thick for where/how it's used. I reckon we should explore the option of either making it slightly smaller or perhaps lighter, and also push it vertically down a pixel or two to be better aligned on the row, both in the dropdowns and the lefthand menu. |
@michalkleiner I agree that the icon could maybe be placed slightly better. But that was actually already the case before, as the icons were only moved to the other side. Maybe @Javi-Ormaechea should have a look and give his opinion. |
Description:
Move the main menu dropdown icons to the right.
Affects:
Fixes #20475
Review