Skip to content

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Aug 29, 2023

Description:

Move the main menu dropdown icons to the right.

Affects:

  • Site selector
  • Period selector
  • Segment selector
  • Dashboard selector
  • Tag Container selector
  • Ab test period selector
  • Version info header
  • Quick access

Fixes #20475

Review

@bx80 bx80 added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Aug 29, 2023
@bx80 bx80 added this to the 5.0.0 milestone Aug 29, 2023
@bx80 bx80 self-assigned this Aug 29, 2023
@bx80 bx80 added the Needs Review PRs that need a code review label Aug 29, 2023
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one relevant comment for this PR, that would be good to changed. Otherwise it's looking fine so far

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Aug 29, 2023
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good now. Merged in the latest changes from 5.x-dev and will wait for the tests to finish before merging...

@michalkleiner
Copy link
Contributor

michalkleiner commented Aug 30, 2023

Apologies for my sometimes annoying sense for tiny details. I can't help it but I think the new chevron icon for the dropdown is too thick for where/how it's used. I reckon we should explore the option of either making it slightly smaller or perhaps lighter, and also push it vertically down a pixel or two to be better aligned on the row, both in the dropdowns and the lefthand menu.

@michalkleiner
Copy link
Contributor

Just compare the line thickness and how it sort of stands out for the chevron compared to the other two icons to the left
Screenshot 2023-08-30 at 5 45 19 PM

@sgiehl
Copy link
Member

sgiehl commented Aug 30, 2023

@michalkleiner I agree that the icon could maybe be placed slightly better. But that was actually already the case before, as the icons were only moved to the other side. Maybe @Javi-Ormaechea should have a look and give his opinion.
I will merge this one now anyway, as it won't change anything in terms of effort if it would be added here or changed in a new PR.

@sgiehl sgiehl merged commit 73b6f79 into 5.x-dev Aug 30, 2023
@sgiehl sgiehl deleted the m20475-dropdown-adjustments branch August 30, 2023 15:54
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

Fix inconsistencies across dropdown elements
4 participants