Avoid checking for raw data if visits log is disabled #21176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caddoo
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When a report page has no data, we currently use
Live.getLastVisitsDetailsto determine if any raw data is available.If that is the case we show a notification that explains, that data was not yet processed and that the visits log can show whats currently happening on the site.
In case the visits log is disabled, the
Live.getLastVisitsDetailsthrows an error, which might then be displayed to the user.As there is no sense in suggesting the user to look at the visits log if it's disabled, this PR simply disables the check for raw data in that case.
fixes #20948
Review