Improve handling of displayed rows in referrer evolution chart #21165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caddoo
reviewed
Aug 23, 2023
a5340cd to
c8c0aa6
Compare
sgiehl
commented
Aug 23, 2023
| { | ||
| if ($this->config->add_total_row) { | ||
| $totalTranslation = Piwik::translate('General_Total'); | ||
| $this->config->selectable_rows[] = array( | ||
| $this->selectableRows['total'] = [ |
There was a problem hiding this comment.
Using the config here instead of the local property actually caused that the totals row was never displayed in the series picker. Not sure if that ever worked, but now it should 🎉
9c79003 to
a1e4766
Compare
caddoo
reviewed
Aug 23, 2023
This was referenced Aug 28, 2023
…more for evolution graph
michalkleiner
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #21051
Review