[DEV-17076] Change translation key for Tour_AddWebsite and also the english translation #21146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Aug 16, 2023
plugins/Tour/tests/UI/expected-screenshots/Tour_widget_complete_some_challenges.png
Outdated
Show resolved
Hide resolved
2360c64 to
67bf85f
Compare
28d4d35 to
9a754f0
Compare
9a754f0 to
02dbca3
Compare
bx80
suggested changes
Aug 18, 2023
There was a problem hiding this comment.
Hi @caddoo, the UI tests look good now 👍
Could you check the following system tests as they appear to be failing due to this change?
Tour\tests\System\APITest
Piwik\Tests\System\OneVisitorTwoVisitsTest
Piwik\Tests\System\NoVisitTest
Piwik\Tests\System\ImportLogsTest
Piwik\Tests\System\BackwardsCompatibility1XTest
|
@caddoo That's fixed the system tests 👍 Some UI tests are still failing because of outdated icons, the expected screenshots are using the old icons but the processed screenshots are using the new icons. I guess the icon update PR was merged since you branched, so a rebase onto the latest 5.x-dev should fix that. |
|
Wow. Only one failing unrelated UI test. Guess we should merge it now. It won't get better 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The language was confusing as it implied you hadn't added one website when in fact you had.
Changed to say 'Add another website'
fixes #21134
Review