FIX Ensure visitor profile country name doesn't overflow #21145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ARSHIL1804, thank you for your contribution. I've left two comments to address and let's see how the tests otherwise run. We may need to update some UI test screenshots and if not, then it indicates were are not testing for this, so adjusting a test would be great to cover this to prevent future regressions. |
sgiehl
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
:after element width was not set so it was overflowing. fixed this by adding the right property so it will remain inside parent container, set text-overflow to ellipsis in case country name goes out of the box.
fixes #20963
Review