Skip to content

Make API method VisitFrequency.get working with multiple sites #21132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2023
Merged

Make API method VisitFrequency.get working with multiple sites #21132

merged 2 commits into from
Aug 8, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 8, 2023

Description:

The API method VisitFrequency.get didn't work correctly, when providing an idSites string like 1,2

fixes #20768

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Aug 8, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Aug 8, 2023
michalkleiner
michalkleiner approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, change looks good, relevant tests are passing.

@sgiehl sgiehl merged commit 22558e4 into 5.x-dev Aug 8, 2023
@sgiehl sgiehl deleted the m20768 branch August 8, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Fatal error: Call to undefined method Piwik\DataTable\Map::getMetadata() in MergeDataTables.php
2 participants
@sgiehl @michalkleiner