Skip to content

Fixes advanced options in tracking code generator (#21064) #21071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 27, 2023

Description:

backports #21064

Review

* Fixes advanced options in tracking code generator

* built vue files

* hide custom vars option if they are not available

* add more tests for tracking code generator

* Update UI test screenshots

* updates expected UI test files

* also add some tests for cross domain linking

* change cross domain text

* updates expected UI test files

---------

Co-authored-by: sgiehl <sgiehl@users.noreply.github.com>
Co-authored-by: Ben <ben.burgess@innocraft.com>
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 27, 2023
@sgiehl sgiehl added this to the 4.15.1 milestone Jul 27, 2023
@sgiehl sgiehl force-pushed the backportjsgenfix branch from 7d741d8 to 3aa0b85 Compare July 27, 2023 12:57
@sgiehl sgiehl merged commit cb21448 into 4.x-dev Jul 27, 2023
@sgiehl sgiehl deleted the backportjsgenfix branch July 27, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

1 participant