Fixes advanced options in tracking code generator #21064
Conversation
ad5c753 to
28bae80
Compare
There was a problem hiding this comment.
I can confirm this allows the toggling of the cross domain linking option and also enables the 'outlinks' option at the same time. The cross domain option is correctly disabled for sites with only single URL configured. I also checked that the other option can be toggled and add their changes to the code 👍
Perhaps it would be good to also change the English translation from 'Enables cross domain linking' to 'Enable cross domain linking' so it's more consistent with the other descriptions?
Also it might be out of scope for this ticket, but when switching sites shouldn't the advanced options be initialized with previously chosen values for the site? Currently if a user wants to update a single tracking code option then they would need to know all the other previously chosen options for the site and remember to set them all again before copying the code otherwise they would inadvertently disable things.
|
@bx80 the selected options aren't stored anywhere, so we currently wouldn't be able to preselect anything. But that could be a new idea we could discuss in a new issue maybe. |
|
I've changed the label text for the input and also added more UI tests to check that the cross domain option works correctly. |
* Fixes advanced options in tracking code generator * built vue files * hide custom vars option if they are not available * add more tests for tracking code generator * Update UI test screenshots * updates expected UI test files * also add some tests for cross domain linking * change cross domain text * updates expected UI test files --------- Co-authored-by: sgiehl <sgiehl@users.noreply.github.com> Co-authored-by: Ben <ben.burgess@innocraft.com>
* Fixes advanced options in tracking code generator (#21064) * Fixes advanced options in tracking code generator * built vue files * hide custom vars option if they are not available * add more tests for tracking code generator * Update UI test screenshots * updates expected UI test files * also add some tests for cross domain linking * change cross domain text * updates expected UI test files --------- Co-authored-by: sgiehl <sgiehl@users.noreply.github.com> Co-authored-by: Ben <ben.burgess@innocraft.com> * built vue files * updates expected UI test files * fix ui tests * updates expected UI test files --------- Co-authored-by: sgiehl <sgiehl@users.noreply.github.com> Co-authored-by: Ben <ben.burgess@innocraft.com>
Description:
fixes #21063
Review