Remove the All Websites link from the site selector #21057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Jul 25, 2023
There was a problem hiding this comment.
This change would be a breaking change. The siteselector element can also be used by plugins to allow selecting sites in forms or similar. In theory a plugin could allow selecting All sites as a valid option, so removing it might have an effect on plugin.
I think the purpose was to remove it from the site selector in the top controls. An easier way would be to simply set the attribute show-ll-sites-item=false
sgiehl
approved these changes
Jul 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #20492
This PR simple removes the 'All websites' link from the site selector. The overview of sites is still always available via the 'All Websites' link on the top right main menu bar.
Review