Skip to content

Make transition overlay more flexible with longer urls/titles #21053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2023
Merged

Make transition overlay more flexible with longer urls/titles #21053

merged 2 commits into from
Jul 24, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 24, 2023

Description:

fixes #21048

Review

@sgiehl sgiehl added this to the 5.0.0 milestone Jul 24, 2023
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 24, 2023
bx80
bx80 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, tests are all passing 👍

@bx80 bx80 merged commit 1ccadfc into 5.x-dev Jul 24, 2023
@bx80 bx80 deleted the m21048 branch July 24, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bx80 bx80 bx80 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Transition window: text overflow
2 participants
@sgiehl @bx80