Skip to content

Fix for spaces in campaign builder URL #21041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2023
Merged

Fix for spaces in campaign builder URL #21041

merged 3 commits into from
Jul 21, 2023

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Jul 20, 2023

Description:

Fixes #21039

This PR adjusts the template markup to prevent extra spaces being included in the campaign builder URL text

Review

@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jul 20, 2023
@bx80 bx80 added this to the 4.15.1 milestone Jul 20, 2023
@bx80 bx80 self-assigned this Jul 20, 2023
@bx80 bx80 changed the title M21039 campaign url fix Fix for spaces in campaign builder URL Jul 20, 2023
@bx80 bx80 added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 20, 2023
@bx80 bx80 changed the base branch from 5.x-dev to 4.x-dev July 20, 2023 05:58
@sgiehl
Copy link
Member

sgiehl commented Jul 20, 2023

@bx80 Any reason for targeting 4.x-dev?

@bx80
Copy link
Contributor Author

bx80 commented Jul 20, 2023

@sgiehl 5.x-dev doesn't have this issue, but we backported the copy to clipboard function to 4.x-dev so the problem is in 4.15.0

@sgiehl sgiehl merged commit c086405 into 4.x-dev Jul 21, 2023
@sgiehl sgiehl deleted the m21039-campaign-url-fix branch July 21, 2023 07:40
@sgiehl
Copy link
Member

sgiehl commented Jul 21, 2023

Ah ok. Was just wondering as you gave the issue the 5.0.0 milestone, but put the PR in 4.15.1 only. I've updated the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@bx80 bx80

Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.15.1
Development

Successfully merging this pull request may close these issues.

There are unnecessary extra spaces in the generated campaign builder URL
2 participants
@bx80 @sgiehl