Skip to content

Fix for language selection error when updating #21038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Jul 20, 2023

Description:

Fixes #20960

This PR disables the CSRF check for the languages manager saveLanguage controller method if it is detected that an update is in progress, this allows the language to be changed on the update screen. A similar exclusion already exists for installation.

I tried adding the language=xxx URL parameter to the updater URL and reloading the page instead of calling saveLanguage, but this only works for the initial updater page and since the language is not saved in the session then subsequent updater pages are not shown in the chosen language.

Review

@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 20, 2023
@bx80 bx80 added this to the 5.0.0 milestone Jul 20, 2023
@bx80 bx80 self-assigned this Jul 20, 2023
@bx80 bx80 added the Needs Review PRs that need a code review label Jul 20, 2023
@sgiehl sgiehl force-pushed the m20960-updater-language branch from 35f8f2d to beeaafa Compare July 24, 2023 06:26
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now

@sgiehl sgiehl merged commit 2e6ae53 into 5.x-dev Jul 24, 2023
@sgiehl sgiehl deleted the m20960-updater-language branch July 24, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

Language selection in Updater no longer works
3 participants