Fix for language selection error when updating #21038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #20960
This PR disables the CSRF check for the languages manager
saveLanguage
controller method if it is detected that an update is in progress, this allows the language to be changed on the update screen. A similar exclusion already exists for installation.I tried adding the
language=xxx
URL parameter to the updater URL and reloading the page instead of callingsaveLanguage
, but this only works for the initial updater page and since the language is not saved in the session then subsequent updater pages are not shown in the chosen language.Review