Skip to content

Hide comparisons on no data page #21037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Hide comparisons on no data page #21037

merged 1 commit into from
Jul 24, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 19, 2023

Description:

fixes #20957

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jul 19, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jul 19, 2023
@michalkleiner
Copy link
Contributor

Is this really the best solution, @sgiehl? I don't have an alternative right at this moment, but it feels non-standard (best word I could come up with).

Would a full page template specifically just for the no-data screen/tabs that wouldn't have any of these components/widgets in it be a better approach, even if it is potentially more work?

@sgiehl
Copy link
Member Author

sgiehl commented Jul 21, 2023

@michalkleiner not sure if that wouldn't be a bit out of scope. In general I think it would make sense to have a simpler layout there. But currently that would mean copying a lot stuff from the dashboard layout to a new simpler layout. I guess to solve that better we would need to restructure the layout. But that could cause other problems if plugins rely on certain layout stuff.

What we could maybe have a some sort of new event that is triggered that can be used to hide the comparison stuff. similar to hiding the date selector. But not sure if that would be much of an improvement.

@michalkleiner
Copy link
Contributor

All good, thanks for the explanation.
An event might be a bit better from the perspective that anything else needing hiding from the no-data screen could also use it, but it's not a dealbreaker for me.

@sgiehl
Copy link
Member Author

sgiehl commented Jul 24, 2023

@michalkleiner Had another thought on it and changed that a bit so it contains some more reusable parts...

@michalkleiner
Copy link
Contributor

Touching parts I even didn't know existed (so I learned something) and I think the broadcast property could potentially be handy later on as well.

This looks better from my perspective than the previous show/hide approach 👍

@sgiehl sgiehl merged commit ae55475 into 5.x-dev Jul 24, 2023
@sgiehl sgiehl deleted the m20957 branch July 24, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

No data page might show selected comparisons
2 participants