Skip to content

Added "keywords" to the default search keyword parameters #21034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

Toflar
Copy link
Contributor

@Toflar Toflar commented Jul 19, 2023

Description:

First time contributor and this is just a little addition, so I didn't read into the entire Matomo docs of how to contribute just yet 😅
Contao's search engine uses keywords instead of keyword as a search query parameter so every time we use Matomo, we have to add keywords to the list of search query parameters. I don't see why keyword is valid but keywords would not be 😊

Review

@sgiehl
Copy link
Member

sgiehl commented Jul 19, 2023

Hey @Toflar
Thanks you contribution! Would you mind changing this PR so it targets the 5.x-dev branch? We are not actively developing on the 4.x-dev branch anymore, as Matomo 5 is about to be release in the next couple of weeks.

@Toflar Toflar changed the base branch from 4.x-dev to 5.x-dev July 19, 2023 13:55
@Toflar Toflar force-pushed the support-keywords-search-parameter branch from e65f237 to 15a1fdc Compare July 19, 2023 13:55
@Toflar
Copy link
Contributor Author

Toflar commented Jul 19, 2023

Sure 😊 Done. Adjusting the screenshots in the functional tests would require setting up the entire test environment - can I ask you to do that maybe? 😅

@sgiehl
Copy link
Member

sgiehl commented Jul 19, 2023

Sure we can update them, once the PR was accepted.

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 19, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jul 19, 2023
@sgiehl
Copy link
Member

sgiehl commented Jul 20, 2023

@Stan-vw Just FYI, I'm going to merge this one. It will make it easier to use the site search tracking feature when using the Contao CMS. As it will no longer require to define a custom query parameter, but will instead work out of the box.

@sgiehl sgiehl added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Needs Review PRs that need a code review labels Jul 20, 2023
@sgiehl sgiehl merged commit a4c3e30 into matomo-org:5.x-dev Jul 20, 2023
@Toflar Toflar deleted the support-keywords-search-parameter branch July 20, 2023 12:07
@Toflar
Copy link
Contributor Author

Toflar commented Jul 20, 2023

Thank you @sgiehl ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Development

Successfully merging this pull request may close these issues.

2 participants