Skip to content

Handle ajax call to resend an invitation correctly #21013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2023
Merged

Handle ajax call to resend an invitation correctly #21013

merged 4 commits into from
Jul 27, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 13, 2023

Description:

Review

@sgiehl sgiehl added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Jul 13, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jul 13, 2023
@michalkleiner
Copy link
Contributor

Conflicts needs resolving.
And a link to the corresponding issue is missing (or at least more info in the PR description) — what problem is this solving?

@sgiehl
Copy link
Member Author

sgiehl commented Jul 24, 2023

@michalkleiner I've resolved the conflicts. Otherwise see AS-274.

@sgiehl sgiehl requested a review from michalkleiner July 27, 2023 11:53
michalkleiner
michalkleiner approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sgiehl sgiehl merged commit b66db30 into 5.x-dev Jul 27, 2023
@sgiehl sgiehl deleted the improveajax branch July 27, 2023 14:31
sgiehl added a commit that referenced this pull request Jul 27, 2023
@sgiehl
Handle ajax call to resend an invitation correctly (#21013)
05903d0 
* Handle ajax call to resend an invitatio correctly

* built vue files

* disallow sending password parameters as get

* update other password usages
@sgiehl sgiehl mentioned this pull request Jul 27, 2023
Merged
11 tasks
sgiehl added a commit that referenced this pull request Jul 27, 2023
@sgiehl
Handle ajax call to resend an invitation correctly (#21073)
4e7a2ad 
* Handle ajax call to resend an invitation correctly (#21013)

* Handle ajax call to resend an invitatio correctly

* built vue files

* disallow sending password parameters as get

* update other password usages

* built vue files

---------

Co-authored-by: sgiehl <sgiehl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @michalkleiner