Skip to content

Increase maximum allowed table size to 1600px #21009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Increase maximum allowed table size to 1600px #21009

merged 1 commit into from
Jul 16, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 13, 2023

Description:

fixes #20861

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 13, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jul 13, 2023
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds an extra 400px to the datatables, including the goals overview table as highlighted by the original issue. From what I can see it works well with smaller and larger screen widths.

Approved because this change has implemented the suggestion made for the ticket 👍

Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this as the best temporary solution for the time being.

@sgiehl sgiehl merged commit a7cb99f into 5.x-dev Jul 16, 2023
@sgiehl sgiehl deleted the m20861 branch July 16, 2023 12:20
@bx80 bx80 mentioned this pull request Jul 24, 2023
11 tasks
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

Width of table on Goals Overview page is not correct
3 participants