Description:

When viewing an evolution graph, existing annotations are fetched using Annotations\Controller::getAnnotationCountForDates(), internal API call is using Annotations\API::getAnnotationCountForDates, to display as icons below the graph:

If your current user is viewing reports using either previous30 or last30 ranges (can be set in "Personal Settings"), the annotation icons are misplaced by one day:

This happens because of the special treatment of the aforementioned ranges in Annotations::getDateRangeForPeriod(). Availalbe dates for annotations are using Date::factory('now'), internally only using subPeriod() in this case, not discarding the current time information.

Later in the process, during Annotations\AnnotationsList::search(), a timestamp comparison is used to select the day an annotation is displayed for. As all annotations are stored without any time information, 2024-01-02 with be matched by, for example, the incorrect 2024-01-01 12:00:00 < 2024-01-02 11:59:59 range, instead of next days 2024-01-02 00:00:00 < 2024-01-02 23:59:59 range, and then displayed at the wrong position.

Discarding the time information after range parsing should fix that problem.

Fixes #21837

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed