Skip to content

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 8, 2024

Description:

fixes #21595

some submodule UI tests may need to be update before/after merging...

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 8, 2024
@sgiehl sgiehl added this to the 5.0.2 milestone Jan 8, 2024
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jan 8, 2024
@sgiehl sgiehl requested a review from a team January 8, 2024 15:31
Copy link
Member

@mneudert mneudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Bandwidth plugin seems to be the only submodule affected, should we include that one directly before merging?

@sgiehl
Copy link
Member Author

sgiehl commented Jan 8, 2024

Sure. I would do that, if this one is good to merge.

@sgiehl sgiehl merged commit 5e2fbe6 into 5.x-dev Jan 8, 2024
@sgiehl sgiehl deleted the dev-17478 branch January 8, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

Evolution of "0%" shown since PHP 8.0
2 participants