Remove Cloudflare instruction from no data page #21778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneudert
reviewed
Jan 8, 2024
mneudert
approved these changes
Jan 8, 2024
Co-authored-by: Marc Neudert <marc@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cloudflare has deprecated their support for "cloudflare apps", see https://cloudflareapps.com/apps/
This means the Matomo Cloudflare app can no longer be used to install the Matomo tracking code.
Therefore this PR removes the suggested installation method from the no data screen.
The detection class is still kept, so Matomo is still be able to detect Cloudflare, as those detection might be used by plugins for other purpose.
fixes #21752
Review