Enable language Gujarati #21769
Merged
Enable language Gujarati #21769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious to understand better — is there a Github issue related to this, did someone request the addition or what is the process around deciding when a language is translated well enough to be included? |
|
There is no official process around that. I had seen a lot of additions for that language in the last translation update PRs and checked the overall translation rate on weblate, which is already at around 30%. There are a lot languages already available with a lower rate, so there is imho no reason to not enable it. |
michalkleiner
requested changes
Jan 7, 2024
There was a problem hiding this comment.
Not sure what needs to get changed where but the integration test failures seem related.
|
A translator name needs to be set on weblate. Should be fixed with the next translation update... |
michalkleiner
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The language Gujarati should meanwhile be translated good enough to enable it by default in the UI.
Review