Skip to content

Ensure opening visitor profile is only triggered once in real time widget #21767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2024
Merged

Ensure opening visitor profile is only triggered once in real time widget #21767

merged 1 commit into from
Jan 7, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 5, 2024

Description:

fixes #21762

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jan 5, 2024
@sgiehl sgiehl added this to the 5.0.2 milestone Jan 5, 2024
@sgiehl sgiehl requested a review from a team January 5, 2024 11:11
bx80
bx80 approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recreated the original issue, then confirmed that this PR fixes it, test failures unrelated 👍

@bx80 bx80 merged commit b263adf into 5.x-dev Jan 7, 2024
@bx80 bx80 deleted the m21762 branch January 7, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bx80 bx80 bx80 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to close visitor profile by clicking 'x' button with one click.
2 participants
@sgiehl @bx80