Skip to content

Avoid possible update problem with MyISAM tables on MySQL 8 #21738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2024
Merged

Avoid possible update problem with MyISAM tables on MySQL 8 #21738

merged 2 commits into from
Jan 2, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 22, 2023

Description:

fixes #21729

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 22, 2023
@sgiehl sgiehl added this to the 5.0.1 milestone Dec 22, 2023
@sgiehl sgiehl requested a review from a team December 22, 2023 16:19
michalkleiner
michalkleiner reviewed Dec 23, 2023
View reviewed changes
michalkleiner
michalkleiner approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor tweak otherwise this is how I would do it as well.

@github-actions GitHub Actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Dec 31, 2023
@sgiehl @michalkleiner
apply review feedback
bc3c5de 
Co-authored-by: Michal Kleiner <michal@innocraft.com>
@sgiehl sgiehl merged commit 80056b4 into 5.x-dev Jan 2, 2024
@sgiehl sgiehl deleted the m21729 branch January 2, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

[Bug] MySQL Update to 5.0.0: The storage engine for the table doesn't support descending indexes
2 participants
@sgiehl @michalkleiner