Skip to content

Hide all sites item in site selector for custom dimension management #21708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

Hide all sites item in site selector for custom dimension management #21708

merged 1 commit into from
Dec 18, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 18, 2023

Description:

There is no sense in showing the all sites item in the site selector on custom dimensions managemant, as choosing it, would bring the user the the all sites dashboard.

refs matomo-org/tag-manager#736

Review

@sgiehl sgiehl added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review labels Dec 18, 2023
@sgiehl sgiehl added this to the 5.0.1 milestone Dec 18, 2023
@sgiehl sgiehl requested a review from a team December 18, 2023 09:35
@sgiehl sgiehl merged commit c03316e into 5.x-dev Dec 18, 2023
@sgiehl sgiehl deleted the allsitescustomdim branch December 18, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Needs Review PRs that need a code review
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @mneudert