Fix possible fatal error in VisitTime report #21679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this covered by some tests somewhere? |
|
Not as far as I know. But I actually also don't know how that could happen. Maybe report row truncation is set too low and the report has an others row... |
bx80
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
I was going to quickly add a unit test, but plugins/VisitTime/functions.php is not a proper class and is being directly included by several column classes in CoreHome, so it would be better to refactor these functions into a more appropriate class in Core or CoreHome and add unit tests there. Which is probably out of scope for this fix.
Maybe it would be good to raise a tech debt ticket to tidy this up at some point?
|
We will need to do that anyway. As some rules of PSR12 forbid global functions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #21677
Review