Use regular expressions to parse segment string into segment logical tree #21669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
bx80
approved these changes
Dec 19, 2023
…ee-negative-lookbehind
sgiehl
added a commit
that referenced
this pull request
Jan 4, 2024
* refactor segment parsing to use a tree structure for logical operators internally instead of flat structure (this is to make re-ordering easier) * first optimization: merge subquery segment conditions together when they are within the same OR sequence or are alone within the same AND sequence * remove todo * fix test and adjust segmentformatter to use new segment expression tree structure * update expected test output * fix CustomVariables plugin * remove code redundancy and add some docs * convert backslash escaped operator characters to urlencoded characters so they are still supported * refactor segment parsing to use a tree structure for logical operators internally instead of flat structure (this is to make re-ordering easier) * first optimization: merge subquery segment conditions together when they are within the same OR sequence or are alone within the same AND sequence * remove todo * fix test and adjust segmentformatter to use new segment expression tree structure * update expected test output * remove code redundancy and add some docs * convert backslash escaped operator characters to urlencoded characters so they are still supported * Update submodule reference * Fix for segment not supported exception for MATCH_IDVISIT_NOT_IN expressions * Update submodule * correctly escape segment value * fix tests * Rework parseTree to avoid removing non-escaping backslashes * Update submodule * Update tests (minor whitespace change) * Temporarily reworked new behaviour to be behind a feature flag for additional testing * Revert feature flag * Use regular expressions to parse segment string into segment logical tree (#21669) Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com> * fix cs --------- Co-authored-by: Ben <ben.burgess@innocraft.com> Co-authored-by: sgiehl <stefan@matomo.org> Co-authored-by: Ben Burgess <88810029+bx80@users.noreply.github.com> Co-authored-by: Michal Kleiner <michal@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Tweak to
parseTreemethod using regular expressionsReview