Skip to content

Fix transition popover for page titles with percent signs #21658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix transition popover for page titles with percent signs #21658

merged 1 commit into from
Dec 8, 2023

Conversation

mneudert
Copy link
Member

@mneudert mneudert commented Dec 7, 2023

Description:

Fixes #21657.

Should this be the time we add some of those edge cases (at least a % and a : in the title) to the general UITestFixture, so we have them readily available for problems like this?

Review

@mneudert mneudert added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Dec 7, 2023
@mneudert mneudert added this to the 5.0.0 milestone Dec 7, 2023
sgiehl
sgiehl reviewed Dec 8, 2023
View reviewed changes
sgiehl
sgiehl approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. At some point it would really be useful to have more edge case tests. Guess we should update our ui test fixture accordingly at some point...

@mneudert mneudert merged commit ce7baf5 into 5.x-dev Dec 8, 2023
@mneudert mneudert deleted the fix-transition-percent-title branch December 8, 2023 13:25
@sgiehl sgiehl modified the milestones: 5.0.0, 5.0.1 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

[Bug] Transition popover does not work for rows with "%"
2 participants
@mneudert @sgiehl