Skip to content

Use website timezone for first/last visit details #21650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2023
Merged

Use website timezone for first/last visit details #21650

merged 2 commits into from
Dec 7, 2023

Conversation

mneudert
Copy link
Member

@mneudert mneudert commented Dec 6, 2023

Description:

Fixes #21645.

Review

@mneudert mneudert added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 6, 2023
@mneudert mneudert added this to the 5.0.0 milestone Dec 6, 2023
@mneudert mneudert requested a review from a team December 6, 2023 18:56
bx80
bx80 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

Would it be worth adding a test with a couple of known times and site timezones to confirm that the firstVisit / lastVisit dates are correctly localized or do you think it's already covered by existing tests?

@mneudert
Copy link
Member Author

mneudert commented Dec 6, 2023

As no test broke during the fix I guess it is not covered well enough 😅 Should be reasonable to add some tests for the Live.getVisitorDetails API around some edge cases where the site timezone has a day change, so I will do that 👍

@mneudert mneudert self-assigned this Dec 6, 2023
@mneudert mneudert force-pushed the visitor-detail-timezone branch from 9085574 to 91a7eaf Compare December 7, 2023 15:00
@mneudert mneudert requested a review from bx80 December 7, 2023 17:53
@mneudert mneudert removed their assignment Dec 7, 2023
bx80
bx80 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the border timezone fixture looks like it could be useful for other future tests too 👍

@bx80 bx80 merged commit 2f30c45 into 5.x-dev Dec 7, 2023
@bx80 bx80 deleted the visitor-detail-timezone branch December 7, 2023 20:06
@sgiehl sgiehl modified the milestones: 5.0.0, 5.0.1 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

[Bug] First/Last visit displayed date doesn't take website timezone into account.
3 participants
@mneudert @bx80 @sgiehl