Skip to content

Remove useless method call #21639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

Remove useless method call #21639

merged 1 commit into from
Dec 5, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 5, 2023

Description:

The method addCustomLogoInfo tries to set some view variables around custom logo usage. But OneClickDone actually is a special view, that only renders invisible content and submits a hidden form. Therefor any custom logo information is unneeded.

fixes #21637

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 5, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Dec 5, 2023
@sgiehl sgiehl requested a review from a team December 5, 2023 10:11
michalkleiner
michalkleiner approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures unrelated.

@sgiehl sgiehl merged commit 7f1bdb2 into 5.x-dev Dec 5, 2023
@sgiehl sgiehl deleted the m21637 branch December 5, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] PHP Deprecated Creation of dynamic property
3 participants
@sgiehl @michalkleiner @mneudert