Description:

With #21521 we introduced a check within the API method SegmentEditor.getAll to filter away segments that aren't valid anymore. Depending on the amount of stored segment, this might take some time.

To avoid the filtering multiple times during a request we should avoid calling the API directly, but use SegmentEditor::getAllSegmentsForSite instead. This method caches the results for the current request.

This PR changes a couple of direct API usages to use SegmentEditor::getAllSegmentsForSite instead.

refs DEV-17463

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed