Prevent cached feedback icons being shown if the feedback plugin is disabled #21559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michal Kleiner <michal@innocraft.com>
|
@bx80 to decouple CoreHome from the Feedback plugin you could try using |
added 3 commits
November 23, 2023 13:54
# Conflicts: # plugins/CoreHome/vue/dist/CoreHome.umd.min.js
|
@sgiehl That worked well and fixes the javascript error when the feedback plugin is disabled. 👍 I've also adjusted the check to see if the feedback plugin is loaded to check directly for the feedback translations rather than the existence of |
mneudert
reviewed
Nov 23, 2023
mneudert
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #21365
This PR adds a check to make sure the Feedback plugin assembly is loaded before showing the rate feature icons, this prevents an issue where the feedback plugin is disabled but the cached javascript still shows the rate feature icons which will then be missing translation strings when clicked.
There is a related issue not fixed by this PR where theFixed by @sgiehl's suggestion belowEnrichedHeadlinecomponent inCoreHomedepends on the feedback plugin and will always try to load it dynamically when widgets are active, if the feedback plugin is disabled then a browser console errorUncaught (in promise) PluginOnDemandLoadError: Loading plugin Feedback on demand failed.however this does not affect the visible user experience and may require larger changes to fix.Review