Description:

PHP 8.x changed how integers and strings are converted. This broke a check for 0 == 'ecommerceOrder', resulting in the "revenue per visit" changing values by not ignoring "ecommerce orders revenue" anymore:

• 5.x: https://builds-artifacts.matomo.org/matomo-org/matomo/5.x-ui-8.3/6880437836/GoalsPages_overview_row_evolution.png
• 4.x: https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-ui-8.3/6884918453/GoalsPages_overview_row_evolution.png

However the code previously intended to include the revenue, so it should be fixed to behave properly on PHP 7.x and reflect the intent of "total revenue".

Should be backported to 4.x.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed