Skip to content

Tabs in glossary are not rendered correctly #21526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2023
Merged

Tabs in glossary are not rendered correctly #21526

merged 2 commits into from
Nov 14, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 13, 2023

Description:

#21523 helped to discover a regression in the glossary. Due to a timing issue, the tabs were not rendered correctly.

Review

@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Nov 13, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Nov 13, 2023
michalkleiner
michalkleiner reviewed Nov 13, 2023
View reviewed changes
@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 13, 2023
@sgiehl sgiehl requested a review from a team November 13, 2023 12:09
@sgiehl sgiehl merged commit 70c6ae8 into 5.x-dev Nov 14, 2023
@sgiehl sgiehl deleted the fixglossary branch November 14, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner left review comments

@mneudert mneudert mneudert left review comments

@caddoo caddoo caddoo approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sgiehl @michalkleiner @mneudert @caddoo