Fix operator handling in subquery segment values #21506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneudert
commented
Nov 8, 2023
Co-authored-by: Michal Kleiner <michal@innocraft.com>
mneudert
added a commit
that referenced
this pull request
Nov 13, 2023
* Add tests for subquery segments * Fix operator handling in subquery segment values * Escape segment values using separate method * Quote delimiter pattern for regex usage Co-authored-by: Michal Kleiner <michal@innocraft.com> --------- Co-authored-by: Michal Kleiner <michal@innocraft.com>
11 tasks
sgiehl
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Fix operator handling in subquery segment values (#21506) * Add tests for subquery segments * Fix operator handling in subquery segment values * Escape segment values using separate method * Quote delimiter pattern for regex usage Co-authored-by: Michal Kleiner <michal@innocraft.com> --------- Co-authored-by: Michal Kleiner <michal@innocraft.com> * Backport test action helper function change * Update test SQL whitespace --------- Co-authored-by: Michal Kleiner <michal@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Having a segment definition with one of the operators (
,and;) in the value can break if the segment requires a subquery expression. This is, for example, the case forPageTitle NotIn "a,b".Should probably be backported to 4.x.
Refs L3-581
Refs #16172
Refs #19617 (should be fixed by backporting)
Review