Description:

The ArchiveSelector is responsible for selecting related archives based on the record name. It should select the archive itself, but also all chunks and subtables.

The generated where statement might currently look like this:

WHERE (
  name = 'CustomReports_customreport_1_0' OR 
  (
       name LIKE 'CustomReports_customreport_1_0%' AND
       ( 
	     SUBSTRING(name, 31, 7) = '_chunk_' OR
             ( SUBSTRING(name, 32, 1) >= '0' AND SUBSTRING(name, 32, 1) <= '9') 
        ) 
    )
)

Problem with this query currently is, that the record name in the like query contains (unescaped) underscores (_). MySQL interprets them as a single char wildcard and the records such might also match e.g. CustomReports_customreport_100_0

This one maybe should be backported to 4.x-dev

fixes L3-590

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed