Skip to content

Exclude wbraid and gbraid URL parameters by default #21467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2023
Merged

Exclude wbraid and gbraid URL parameters by default #21467

merged 1 commit into from
Nov 1, 2023

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 31, 2023

Description:

Similar to #21452

We have been already excluding gclid. In compliance with Apple’s ATT policy changes, Google is no longer sending GCLID parameters on iOS traffic coming from various Google apps. Google has introduced new URL parameters termed WBRAID and GBRAID to be compliant with Apple’s ATT framework.

We should exclude these by default as well to keep log_action table fast, reports useful, and record less personal data when it's not needed.

Review

@tsteur tsteur added the Needs Review PRs that need a code review label Oct 31, 2023
@michalkleiner michalkleiner removed the Needs Review PRs that need a code review label Nov 1, 2023
@michalkleiner michalkleiner added this to the 5.1.0 milestone Nov 1, 2023
@michalkleiner michalkleiner added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 1, 2023
michalkleiner
michalkleiner approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@michalkleiner michalkleiner modified the milestones: 5.1.0, 5.0.0 Nov 1, 2023
@michalkleiner
Copy link
Contributor

@sgiehl please check the labels assigned and the milestone and merge if ok, thanks!

@tsteur tsteur removed the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 1, 2023
@tsteur tsteur changed the title Exclude wbraid and gbraid parameters by default Exclude wbraid and gbraid URL parameters by default Nov 1, 2023
@tsteur tsteur merged commit 939b431 into 5.x-dev Nov 1, 2023
@tsteur tsteur deleted the wbraid branch November 1, 2023 21:43
caddoo pushed a commit that referenced this pull request Nov 5, 2023
@tsteur @caddoo
Exclude wbraid and gbraid parameters by default (#21467)
4d8eeff
caddoo pushed a commit that referenced this pull request Nov 5, 2023
@tsteur @caddoo
Exclude wbraid and gbraid parameters by default (#21467)
ca3b078
caddoo pushed a commit that referenced this pull request Nov 5, 2023
@tsteur @caddoo
Exclude wbraid and gbraid parameters by default (#21467)
9b5313d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tsteur @michalkleiner