Fix problem with incorrectly placed modals #21461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneudert
approved these changes
Oct 31, 2023
michalkleiner
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In some weird cases modals might currently be placed incorrect, causing them to get partially hidden when being placed with a negative top position.
The positioning is handled by jQuery UI. It seems like for some reason the collision detection of jquery doesn't work properly resulting in a negative top value.
I tried debugging that for a while, but decided not to waste more time. The simple fix in this PR should fix the problem by simply unsetting negative top values to ensure the element is correctly visible.
fixes DEV-17273
Review