Exclude twclid URL parameter by default #21452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://business.twitter.com/en/help/campaign-measurement-and-analytics/conversion-tracking-for-websites.html > The X Pixel already automatically passes twclid from URL or first-party cookie. This parameter can be optionally used to force attribution to a certain ad click. Just like the other ad related IDs we should exclude this one by default as well to reduce number of unique log_actions.
sgiehl
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Might be good to add a test case here to avoid regressions:
matomo/tests/PHPUnit/Integration/Tracker/ActionTest.php
Lines 173 to 187 in 1303df1
|
Good idea @sgiehl Added a test case |
sgiehl
approved these changes
Oct 30, 2023
11 tasks
caddoo
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Exclude twclid URL parameter by default see https://business.twitter.com/en/help/campaign-measurement-and-analytics/conversion-tracking-for-websites.html > The X Pixel already automatically passes twclid from URL or first-party cookie. This parameter can be optionally used to force attribution to a certain ad click. Just like the other ad related IDs we should exclude this one by default as well to reduce number of unique log_actions. * Add test case
caddoo
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Exclude twclid URL parameter by default see https://business.twitter.com/en/help/campaign-measurement-and-analytics/conversion-tracking-for-websites.html > The X Pixel already automatically passes twclid from URL or first-party cookie. This parameter can be optionally used to force attribution to a certain ad click. Just like the other ad related IDs we should exclude this one by default as well to reduce number of unique log_actions. * Add test case
caddoo
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Exclude twclid URL parameter by default see https://business.twitter.com/en/help/campaign-measurement-and-analytics/conversion-tracking-for-websites.html > The X Pixel already automatically passes twclid from URL or first-party cookie. This parameter can be optionally used to force attribution to a certain ad click. Just like the other ad related IDs we should exclude this one by default as well to reduce number of unique log_actions. * Add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://business.twitter.com/en/help/campaign-measurement-and-analytics/conversion-tracking-for-websites.html
Just like the other ad related IDs we should exclude this one by default as well to reduce number of unique log_actions thus speeding up especially queries where a segment "action contains $value".
refs #19581
Review