Fix incorrect URL parameter in update notification #21447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we perhaps wrap https://github.com/matomo-org/matomo/blob/5.x-dev/plugins/Morpheus/javascripts/piwikHelper.js#L36-L58 in |
|
I think that would be a better outcome than a hard fail, it's possible that future usage of the external link methods, either in core or plugins, could result in invalid URLs causing a similar crash, so minimizing the potential impact makes sense 👍 |
Co-authored-by: Michal Kleiner <michal@innocraft.com>
michalkleiner
approved these changes
Oct 29, 2023
caddoo
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Fix incorrect URL parameter * Fix incorrect URL parameter in JS tracking code generator component * built vue files * Improve error handling of invalid URLs in _pk_externalRawLink * Update plugins/Morpheus/javascripts/piwikHelper.js Co-authored-by: Michal Kleiner <michal@innocraft.com> * built vue files * Bump stalled tests --------- Co-authored-by: Michal Kleiner <michal@innocraft.com> Co-authored-by: michalkleiner <michalkleiner@users.noreply.github.com> Co-authored-by: bx80 <bx80@users.noreply.github.com>
caddoo
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Fix incorrect URL parameter * Fix incorrect URL parameter in JS tracking code generator component * built vue files * Improve error handling of invalid URLs in _pk_externalRawLink * Update plugins/Morpheus/javascripts/piwikHelper.js Co-authored-by: Michal Kleiner <michal@innocraft.com> * built vue files * Bump stalled tests --------- Co-authored-by: Michal Kleiner <michal@innocraft.com> Co-authored-by: michalkleiner <michalkleiner@users.noreply.github.com> Co-authored-by: bx80 <bx80@users.noreply.github.com>
caddoo
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Fix incorrect URL parameter * Fix incorrect URL parameter in JS tracking code generator component * built vue files * Improve error handling of invalid URLs in _pk_externalRawLink * Update plugins/Morpheus/javascripts/piwikHelper.js Co-authored-by: Michal Kleiner <michal@innocraft.com> * built vue files * Bump stalled tests --------- Co-authored-by: Michal Kleiner <michal@innocraft.com> Co-authored-by: michalkleiner <michalkleiner@users.noreply.github.com> Co-authored-by: bx80 <bx80@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #21446
Corrects an invalid URL causing a JS crash when an update is detected.
Review