Skip to content

Fix for e.externalRawLink is not a function error #21435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2023
Merged

Fix for e.externalRawLink is not a function error #21435

merged 4 commits into from
Oct 25, 2023

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Oct 25, 2023

Description:

Fixes #21432

This PR fixes an issue where the externalRawLink method was being used to format links on the site management page but had not been made available as a vue global property resulting in a runtime error.

Review

@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Oct 25, 2023
@bx80 bx80 self-assigned this Oct 25, 2023
@bx80 bx80 requested review from michalkleiner and caddoo October 25, 2023 01:17
@michalkleiner michalkleiner mentioned this pull request Oct 25, 2023
Merged
11 tasks
@michalkleiner
Copy link
Contributor

UI tests failures unrelated

@bx80 bx80 merged commit e6b8cf6 into 5.x-dev Oct 25, 2023
@bx80 bx80 deleted the m21432-externalrawlink-vue-fix branch October 25, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

@caddoo caddoo Awaiting requested review from caddoo

Assignees

@bx80 bx80

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Websites -> Manage page not working
2 participants
@bx80 @michalkleiner