Enable searching on the device type report #21412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
caddoo
approved these changes
Oct 18, 2023
michalkleiner
approved these changes
Oct 18, 2023
sgiehl
reviewed
Oct 30, 2023
| @@ -27,7 +27,7 @@ protected function init() | |||
|
|
|||
| public function configureView(ViewDataTable $view) | |||
| { | |||
| $view->config->show_search = false; | |||
| $view->config->show_search = true; | |||
There was a problem hiding this comment.
Note: You could have also simply removed that line, as true is the default value. Only reports that don't want to use the search need to overwrite the value...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Toggles the searching function for the device type report
Fixes #21406
Review