[DEV-17228] Add markup and content for premium plugins promos [4.x] #21403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
commented
Oct 15, 2023
| <a class="btn" target="_blank" rel="noreferrer noopener" href="{{ plugin.shop.url|default('')|e('html_attr') }}"> | ||
| {{ 'ProfessionalServices_CTAStartFreeTrial'|translate }} | ||
| </a> | ||
| <a class="learn-more" href="#" vue-directive="Marketplace.PluginName" vue-directive-value="{{ { pluginName: plugin.name }|json_encode }}" aria-label="{{ 'ProfessionalServices_CTALearnMore'|translate(plugin.displayName) }}"> |
There was a problem hiding this comment.
Just highlighting here that this is the only difference compared to the code for 5.x where the directive is called CorePluginsAdmin.PluginName and here for 4.x it's called Marketplace.PluginName.
fac829f to
61c324a
Compare
ac1c68d to
80e784f
Compare
80e784f to
3f416c3
Compare
caddoo
approved these changes
Oct 17, 2023
Base automatically changed from
dev-17228-add-menu-item-for-premium-plugins
to
4.x-dev
October 17, 2023 01:54
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
72449c5 to
cac4cb2
Compare
… off by default for UI tests
|
Port of #21402 to 4.x-dev. |
bx80
approved these changes
Oct 29, 2023
I can help here, it's just matching those main menu item names that appear when you use the premium plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
4.x version of #21402
Review