[DEV-17228] Add markup and content for premium plugins promos #21402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
a095432 to
a007cc5
Compare
michalkleiner
commented
Oct 16, 2023
|
Also there might be some potential to abstract some parts of the widget configure and render methods into a base promo widget class of sorts. I looked into that and the complicating factor is that the configure method is static and render is instance, so if we e.g. wanted to provide new methods for the promoted plugin name or its display name etc, it would again be a mix of static and instance methods that can't be called from a parent class. Perhaps I didn't see the right way through it but it felt it was becoming too convoluted for little benefit. |
Base automatically changed from
dev-17228-add-menu-item-for-premium-plugins-5
to
5.x-dev
October 16, 2023 05:27
9f9e01a to
6149202
Compare
caddoo
approved these changes
Oct 16, 2023
michalkleiner
commented
Oct 16, 2023
… as needed This is needed as config override from UI tests has lower priority than ui-test.php file overrides.
It seems the DI config isn't passed to the class properly during the UI tests so using its static method using config provided by the DI works better.
…plugins-promos-5x
… by default and only enabled when required
Tidying up the config within the test where it's set didn't work.
aad8c6f to
9aab746
Compare
3fd873e to
4847dca
Compare
ac6bb13 to
bb7592e
Compare
|
@matomo-org/core-reviewers this is finally good for another review. |
michalkleiner
commented
Oct 26, 2023
caddoo
approved these changes
Oct 26, 2023
bx80
approved these changes
Oct 27, 2023
michalkleiner
added a commit
that referenced
this pull request
Oct 27, 2023
caddoo
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Add initial template for plugin promos * Move image to Card so grid can be used at card level * Add plugin promo screenshots * Adjust content * Use widget template instead of controller view * Populate plugin promo content * Remove enable/disable variable override * Remove legal info markup as not yet designed * Unify image alt text and remove help url property * Prepare promo widgets for refactoring for reusability * Integrate CTA links * Rename A/B Testing image to match plugin name * Use marketplace plugin info where possible * Update Start free trial CTA to open marketplace in new tab * Move promo features text to lang file * Add UI tests * Update UI test screenshots from CI * Simplify UI test selector * Update UI tests * Use full plugin names in category ids * Disable Professional Services ads for UI tests apart from the plugin itself * Fix typo in test method name * Add new widget categories to widgets test * Add integration test without professional services widgets/categories * Update expected list of report pages returned by the API in a system test * Added missing externalLink method reference to the vue global properties * built vue files * Use test.vars. approach to disable professional services for UI tests as needed This is needed as config override from UI tests has lower priority than ui-test.php file overrides. * Remove test dependency on Advertising class It seems the DI config isn't passed to the class properly during the UI tests so using its static method using config provided by the DI works better. * Reverse logic so that Professional Services are disabled for UI tests by default and only enabled when required * Ensure page is reloaded after config change * Update screenshot from CI run * Reset UI tests config before each test Tidying up the config within the test where it's set didn't work. * Move mouse out of viewport to prevent any unwanted hover effects * Update tests from CI * Update language to use visitor instead of user * Update UI test screenshots after content change --------- Co-authored-by: Ben <ben.burgess@innocraft.com>
caddoo
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Add initial template for plugin promos * Move image to Card so grid can be used at card level * Add plugin promo screenshots * Adjust content * Use widget template instead of controller view * Populate plugin promo content * Remove enable/disable variable override * Remove legal info markup as not yet designed * Unify image alt text and remove help url property * Prepare promo widgets for refactoring for reusability * Integrate CTA links * Rename A/B Testing image to match plugin name * Use marketplace plugin info where possible * Update Start free trial CTA to open marketplace in new tab * Move promo features text to lang file * Add UI tests * Update UI test screenshots from CI * Simplify UI test selector * Update UI tests * Use full plugin names in category ids * Disable Professional Services ads for UI tests apart from the plugin itself * Fix typo in test method name * Add new widget categories to widgets test * Add integration test without professional services widgets/categories * Update expected list of report pages returned by the API in a system test * Added missing externalLink method reference to the vue global properties * built vue files * Use test.vars. approach to disable professional services for UI tests as needed This is needed as config override from UI tests has lower priority than ui-test.php file overrides. * Remove test dependency on Advertising class It seems the DI config isn't passed to the class properly during the UI tests so using its static method using config provided by the DI works better. * Reverse logic so that Professional Services are disabled for UI tests by default and only enabled when required * Ensure page is reloaded after config change * Update screenshot from CI run * Reset UI tests config before each test Tidying up the config within the test where it's set didn't work. * Move mouse out of viewport to prevent any unwanted hover effects * Update tests from CI * Update language to use visitor instead of user * Update UI test screenshots after content change --------- Co-authored-by: Ben <ben.burgess@innocraft.com>
caddoo
pushed a commit
that referenced
this pull request
Nov 5, 2023
* Add initial template for plugin promos * Move image to Card so grid can be used at card level * Add plugin promo screenshots * Adjust content * Use widget template instead of controller view * Populate plugin promo content * Remove enable/disable variable override * Remove legal info markup as not yet designed * Unify image alt text and remove help url property * Prepare promo widgets for refactoring for reusability * Integrate CTA links * Rename A/B Testing image to match plugin name * Use marketplace plugin info where possible * Update Start free trial CTA to open marketplace in new tab * Move promo features text to lang file * Add UI tests * Update UI test screenshots from CI * Simplify UI test selector * Update UI tests * Use full plugin names in category ids * Disable Professional Services ads for UI tests apart from the plugin itself * Fix typo in test method name * Add new widget categories to widgets test * Add integration test without professional services widgets/categories * Update expected list of report pages returned by the API in a system test * Added missing externalLink method reference to the vue global properties * built vue files * Use test.vars. approach to disable professional services for UI tests as needed This is needed as config override from UI tests has lower priority than ui-test.php file overrides. * Remove test dependency on Advertising class It seems the DI config isn't passed to the class properly during the UI tests so using its static method using config provided by the DI works better. * Reverse logic so that Professional Services are disabled for UI tests by default and only enabled when required * Ensure page is reloaded after config change * Update screenshot from CI run * Reset UI tests config before each test Tidying up the config within the test where it's set didn't work. * Move mouse out of viewport to prevent any unwanted hover effects * Update tests from CI * Update language to use visitor instead of user * Update UI test screenshots after content change --------- Co-authored-by: Ben <ben.burgess@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up PR for #21401
Review