Add premium plugin menu items to professional services (V5) #21401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bx80
approved these changes
Oct 13, 2023
plugins/ProfessionalServices/tests/Unit/PromoWidgetApplicableTest.php
Outdated
Show resolved
Hide resolved
|
I've added two extra checks as per the requirements — Marketplace enabled, Internet services enabled. Otherwise it works as expected. |
michalkleiner
approved these changes
Oct 15, 2023
11 tasks
|
@caddoo it seems that me adding the checks for Marketplace and Internet features broke the newly added test. Also worth noting (though unrelated to the changes here) is that some other tests started failing simply by adding a new test. |
6996bc5 to
153f019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
5.x version of #21394
This is an addition to the professional services plugin that will show premium plugins in the reporting menu with an empty widget if:
The content / title of the widgets is being worked on in a seperate PR.
In this PR I have force disabled showing the menu items intentionally so we can merge this without impact, there are unit test s for the logic around whether to show the item or not.
Once approved / merged, the follow up for the promotional page can be added.
Screenshot when the logic is used without being fixed as false.
Review