Skip to content

Fix visits log might show incorrect action for groups #20393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Fix visits log might show incorrect action for groups #20393

merged 3 commits into from
Mar 8, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 23, 2023

Description:

The incorrect behavior is reproducible if multiple pageviews are tracked with the same pageview id. e.g.

_paq.push(['setPageViewId', 'abcdef']);
_paq.push(['setDocumentTitle', 'view 1']);
_paq.push(['trackPageView']);
_paq.push(['setDocumentTitle', 'view 2']);
_paq.push(['trackPageView']);
_paq.push(['setDocumentTitle', 'view 3']);
_paq.push(['trackPageView']);

fixes #20391

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 23, 2023
@sgiehl sgiehl added this to the 4.13.4 milestone Feb 23, 2023
@sgiehl sgiehl added the Needs Review PRs that need a code review label Feb 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Mar 3, 2023
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bx80 bx80 merged commit c97662c into 4.x-dev Mar 8, 2023
@bx80 bx80 deleted the m20391 branch March 8, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stale The label used by the Close Stale Issues action
Development

Successfully merging this pull request may close these issues.

Incorrect visualization of page titles in visitor profile
2 participants