Fix compatibility of minimum PHP version check with older versions #20358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Feb 14, 2023
There was a problem hiding this comment.
@bx80 The file still doesn't seem to be compatible with older PHP versions. There is a usage of a short array syntax on line 215.
Also we can't get the file compatible for PHP lower than 5.3 actually, as we are using namespaced classes inside it.
Btw. you can simply paste the files content on https://3v4l.org/ and check which php version it would run with...
…patible with PHP 5.3 as namespaces are in use
|
@sgiehl I'd just tested locally with PHP5.6, hard to believe anyone would still be running < 5.5 at this stage almost 10yrs since it was released. I've removed the short array syntax and updated the header comment to state that the file should be compatible with PHP 5.3 (since we're using namespaces). Thanks for the 3v4l link 👍 |
sgiehl
reviewed
Feb 15, 2023
sgiehl
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #20350
The
testMinimumPhpVersion.phpcheck contains type hints which are not compatible with PHP < 7. When attempting to run command line tasks with PHP 5.6 this caused the following error to be shown instead of an incompatible version warning:PHP Fatal error: Default value for parameters with a class type hint can only be NULL in /var/www/matomo/core/testMinimumPhpVersion.php on line 128Although the minimum PHP version for Matomo is 7.2+, this specific file needs to be able to run on any PHP version > 4 so it can show the version error.
This PR removes the type hints.
Review