Skip to content

Fix for PHP8 type error on NFS diagnostic check #20324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fix for PHP8 type error on NFS diagnostic check #20324

merged 1 commit into from
Feb 7, 2023

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Feb 7, 2023

Description:

Makes sure the NFS diagnostic check exec command output is actually an array before attempting to count it.

Fixes #20323

Review

@bx80 bx80 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 7, 2023
@bx80 bx80 added this to the 4.13.4 milestone Feb 7, 2023
@bx80 bx80 self-assigned this Feb 7, 2023
@bx80 bx80 added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 7, 2023
@sgiehl sgiehl merged commit db50392 into 4.x-dev Feb 7, 2023
@sgiehl sgiehl deleted the m20323-nfs-check-fix branch February 7, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@bx80 bx80

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.14.0
Development

Successfully merging this pull request may close these issues.

PHP8: PHP Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given
2 participants
@bx80 @sgiehl