Also unset link token when accepting an invite #20298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Figured this could maybe cause some potential bugs in the future as we almost used something like `$isPendingUser = invite_token is not null or invite_link_token is not null` to check if a user is pending invite. One could assume that if the link token is still set, that the invite is still pending when in reality it isn't and might be better to simply unset it? If not, feel free to close this PR. No problem.
bx80
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
This makes sense to me 👍
The separate link token was added in a revision to the original PR, so clearing it when accepting the invite might have been missed.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- Code review done
- n/a Tests were added if useful/possible
- n/a Reviewed for breaking changes
- n/a Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Figured this could maybe cause some potential bugs in the future as we almost used something like
$isPendingUser = invite_token is not null or invite_link_token is not nullto check if a user is pending invite. One could assume that if the link token is still set, that the invite is still pending when in reality it isn't and might be better to simply unset it? If not, feel free to close this PR. No problem.Review