Skip to content

Trim spaces from login email in password reset process if some are set #20296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Feb 1, 2023

Description:

I went through the password reset process earlier and wondered for a while why it wasn't working. Then noticed there was a tab or white space at the end of the email. This will remove these automatically and can avoid some user frustrations

Review

I went through the password reset process earlier and wondered for a while why it wasn't working. Then noticed there was a tab or white space at the end of the email. This will remove these automatically and can avoid some user frustrations
@tsteur tsteur added the Needs Review PRs that need a code review label Feb 1, 2023
@tsteur tsteur added this to the 4.13.4 milestone Feb 1, 2023
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sgiehl sgiehl merged commit 18eedb1 into 4.x-dev Feb 1, 2023
@sgiehl sgiehl deleted the trimloginmail branch February 1, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

2 participants