Skip to content

[Vue] fix FocusIf, use property in binding value not modifier #20291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2023
Merged

[Vue] fix FocusIf, use property in binding value not modifier #20291

merged 1 commit into from
Jan 31, 2023

Conversation

diosmosis
Copy link
Member

Description:

Not sure why I originally used a modifier here, but it doesn't work, using a binding value seems to.

Fixes #20285

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 31, 2023
@diosmosis diosmosis added this to the 4.13.4 milestone Jan 31, 2023
sgiehl
sgiehl approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that locally and it fixes the issue 👍

@sgiehl sgiehl merged commit 33d4492 into 4.x-dev Jan 31, 2023
@sgiehl sgiehl deleted the vue-fix-focus-if branch January 31, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
4.14.0
Development

Successfully merging this pull request may close these issues.

Tabbing (tab navigation with keyboard) is not working in Matomo 4.13 (regression)
2 participants
@diosmosis @sgiehl