Remove unneeded table from query when querying conversions by page view to increase performance #20272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86712bf to
2dfc2ea
Compare
check table isn't used
2dfc2ea to
345b8b5
Compare
bx80
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
The archiving errors I mentioned in L3-313 when testing removing the table were actually caused by a malformed segment in my local data, I saw the word "subquery" in the error and incorrectly assumed the table removal was the cause 🤦♂️
All the tests pass and the generated query (without the log_visit table) works with segments when manually run along with the create segment temp table queries. 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- n/a Wording review done
- n/a Code review done
- Covered by existing Tests were added if useful/possible
- n/a Reviewed for breaking changes
- n/a Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
@bx80 see L3-13 comment there. It looks like the tests pass but maybe there was something else around segments that could break not covered by tests?
Review